This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
chore: update ipfs dep #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates ipfs to 0.37.0-rc.0. Due to the constructor changes in this version the examples have also been updated. This required an update of `react-live` to a version that supports async/await. Unfortunately in this new version styling for syntax highlighting is done by "theme" objects not CSS so there are a bunch of changes that are fallout from this. Notably, I've updated the `syntax-highlighter` component to use the same highlight method as `react-live` so that we can re-use the theme object and not also import the theme as a CSS file. I also switchied to using the `Prism` instance provided by `prism-react-renderer` that `react-live` uses instead of importing `prismjs`. This should reduce overall bundle size. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
54 tasks
lidel
approved these changes
Aug 13, 2019
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
lidel
reviewed
Aug 15, 2019
package.json
Outdated
| @@ -35,17 +35,16 @@ | |||
| "gatsby-plugin-postcss": "^2.0.0", | |||
| "gatsby-plugin-react-helmet": "^3.0.1", | |||
| "intersection-observer": "~0.5.0", | |||
| "ipfs": "~0.36.1", | |||
| "ipfs": "^0.37.0", | |||
There was a problem hiding this comment.
@alanshaw CI fails with Dependency ipfs had version ^0.37.0 - development (e.g. < 1.0.0) versions should start with a ~
Suggested change
| "ipfs": "^0.37.0", | |
| "ipfs": "~0.37.0", |
(probably needs update of package-lock too)
|
@PedroMiguelSS are you still around for reviewing and merging changes to the website, or should we find a new maintainer? :) |
|
Merging as we have an approving review, tests are passing and 0.37 has been out for ages now and the examples really need to be changed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ipfs to 0.37.0.
Due to the constructor changes in this version the examples have also been updated.
This required an update of
react-liveto a version that supports async/await. Unfortunately in this new version styling for syntax highlighting is done by "theme" objects not CSS so there are a bunch of changes that are fallout from this.Notably, I've updated the
syntax-highlightercomponent to use the same highlight method asreact-liveso that we can re-use the theme object and not also import the theme as a CSS file.I also switchied to using the
Prisminstance provided byprism-react-rendererthatreact-liveuses instead of importingprismjs. This should reduce overall bundle size.