Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add enable pubsub/namesys extra opt #49

Merged
merged 3 commits into from
Sep 10, 2020
Merged

feat: Add enable pubsub/namesys extra opt #49

merged 3 commits into from
Sep 10, 2020

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Sep 9, 2020 •
edited
Loading

Description

Add enableNamesysPubsub & enablePubsubExperiment methods

EnablePubsubExperiment:

equivalent to --enable-pubsub-experiment

Instantiate the ipfs node with the experimental pubsub feature enabled.

EnableNamesysPubsub:

equivalent to --enable-namesys-pubsub

Enable IPNS record distribution through pubsub; enables pubsub.

How To

Android:

IPFS ipfs = new IPFS(activity.getApplicationContext());

ipfs.enablePubsubExperiment();
// or
ipfs.enableNamesysPubsub()

ipfs.start();

iOS:

guard let ipfs = try IPFS() else {
  throw IPFSError
}

ipfs.enablePubsubExperiment()
// or
ipfs.enableNamesysPubsub()

ipfs.start();

Related

@gfanton gfanton requested a review from aeddi September 9, 2020 13:57
@gfanton gfanton self-assigned this Sep 9, 2020
@gfanton gfanton force-pushed the feat/add-pubsub-opt branch from e33ffdf to bdf9542 Compare September 9, 2020 14:06
@gfanton gfanton mentioned this pull request Sep 9, 2020
Closed
@gfanton
fix: update & fix go mod
d6caf1d 
- remove go mod vendor

Signed-off-by: Guilhem Fanton <guilhem.fanton@gmail.com>
@gfanton gfanton force-pushed the feat/add-pubsub-opt branch 2 times, most recently from 0f6b050 to dc5cbf6 Compare September 10, 2020 06:48
@gfanton
feat: Add enable pubsub/namesys extra opt
33af183 
Signed-off-by: Guilhem Fanton <guilhem.fanton@gmail.com>
@gfanton gfanton force-pushed the feat/add-pubsub-opt branch from dc5cbf6 to 33af183 Compare September 10, 2020 07:14
aeddi
aeddi requested changes Sep 10, 2020
View reviewed changes
android/bridge/src/main/java/ipfs/gomobile/android/IPFS.java Outdated Show resolved Hide resolved
android/bridge/src/main/java/ipfs/gomobile/android/IPFS.java Outdated Show resolved Hide resolved
ios/Bridge/GomobileIPFS/Sources/IPFS.swift Outdated Show resolved Hide resolved
ios/Bridge/GomobileIPFS/Sources/IPFS.swift Outdated Show resolved Hide resolved
packages/Makefile Outdated Show resolved Hide resolved
packages/Makefile Outdated Show resolved Hide resolved
packages/Makefile Outdated Show resolved Hide resolved
@gfanton @aeddi
chore: Apply suggestions from code review
0e55bef 
- fix docs & make rules

Co-authored-by: Antoine Eddi <antoine.e.b@gmail.com>
Signed-off-by: Guilhem Fanton <guilhem.fanton@gmail.com>
@gfanton gfanton force-pushed the feat/add-pubsub-opt branch from 14d1fc0 to 0e55bef Compare September 10, 2020 12:26
@aeddi aeddi self-requested a review September 10, 2020 12:29
aeddi
aeddi approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aeddi aeddi merged commit 9b44615 into master Sep 10, 2020
@aeddi aeddi deleted the feat/add-pubsub-opt branch September 10, 2020 16:19
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeddi aeddi aeddi approved these changes

Assignees

@gfanton gfanton

Labels
released
Projects
None yet
Milestone
2. Improve the developer experience
Development

Successfully merging this pull request may close these issues.

How to enable pubsub
3 participants
@gfanton @aeddi @moul