Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New Share Screen (ipfs-share-files) #642

Closed
wants to merge 1 commit into from

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 17, 2018

This PR adds bundled and minimized version of ipfs-share-files and opens it in addition to the old Share screen (in a new tab). After app is ready we will remove the old screen, for now we open both:

2018-12-17-014732_1279x948_scrot

Thanks to this code in ipfs-redux-bundle the Share App is able to detect it runs inside of IPFS Companion and use its API instance directly.

@fsdiogo FYI to update to a new version of ipfs-share-app we will just change the CID in build:share script:

https://github.com/ipfs-shipyard/ipfs-companion/blob/eaf97847b0abe4a21258c9b665698576797a6c56/package.json#L33

TODO

This adds prebuild, bundled and minimized version of
https://github.com/ipfs-shipyard/ipfs-share-files
and opens it in addition to the old upload screen
in a new tab.

After app is ready we will remove old screen,
for now both open.
@jessicaschilling
Copy link
Contributor

@lidel Is there any point in keeping this PR around?

@lidel
Copy link
Member Author

lidel commented Apr 15, 2020

Closing. This PR mostly acted as a PoC, but was never meant to be:

Since then, we've had issues with browser extension stores around the build reproducibility (that is why we don't bundle webui on Firefox) and bundling this would be a similar source of trouble.

@lidel lidel closed this Apr 15, 2020
@lidel lidel deleted the feat/ipfs-share-files branch April 15, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants