Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy shareable link during file import #834

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 12, 2019

@ericronne suggested that best interface is no interface, so..

This PR adds automatic copying of shareable link to clipboard when user imports a file via IPFS Companion UI. Closes #833.

Details

Import file via context menu or "Share files via IPFS" from the main menu.
A system notification in system-native look will be shown at the same time imported file is being opened in Web UI:

2019-12-12--13-32-56

This notification is the same as one when user manually copies via:

2019-12-12--13-34-46

@lidel lidel changed the title feat: copy shareable link during import feat: copy shareable link during file import Dec 12, 2019
@lidel lidel added this to the v2.10 milestone Dec 12, 2019
@lidel lidel merged commit 3c8c57d into master Dec 12, 2019
@lidel lidel deleted the feat/autocopy-after-import branch December 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files: improve sharing flow from IPFS Companion
1 participant