-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trim icons and transition SVG path elements #3
Conversation
Just pushed a commit to put a transition into SVG paths. |
Don't merge this yet @olizilla 😄 |
@olizilla now using the trimmed icons. I think it's ready to merge 😄 |
ipfs.css
Outdated
@@ -369,7 +369,8 @@ See: https://github.com/ipfs-shipyard/ipfs-css | |||
|
|||
.ipfs-gradient-0 { background-image: linear-gradient(to top, #041727 0%,#043b55 100%); } | |||
|
|||
.transition-all { | |||
.transition-all, | |||
.transition-all path { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change related? What does it do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also applies the transition to the SVG paths
@hacdias we don't need to add http://jsbin.com/celezal/5/edit?html,css,output The fill and stroke styles follow the cascade as long as nothing overrides them. The svgs need another pass over them to remove the inline styles, and unneeded classes and ids. Of note, being able to just set a single fill or stroke colour and have it sensibly change the colour of an svg is depends on the construction of the svg. We'll need to eyeball them all, which sounds like we need an svg preview page. I can take a look at that later if your deep in desktop code. |
@olizilla thanks for noticing. I thought I had tried and it didn't work. Probably I got something wrong. I just cleaned the SVGs by removing the classes and IDs that weren't needed and removed the This is the first week of my uni semester so I'm still getting on a new routine 😄 and I'll be a bit less active this week. Although, I won't continue Desktop until this PR is finished. I'm now trying to finish js-ipfs#1230 and trying to finish some homework. Do you want to do the Preview Page in a separate PR or still here? |
Enjoy uni! The svg preview page can wait. I'll have a quick look at the svgs and get this merged. |
Thanks @olizilla 😄 |
Any developments on this? 😃 |
Hello:) yes, they are correct. I didn't make glyph version for all |
@olizilla cool! You should commit that page too 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Cool! Thanks @olizilla! Could you ping me when you publish a new version, please? 😄 |
@hacdias ipfs-css@0.3.0 is a thing now! |
Thank yooou! |
Just trimming the icons and adding a new one 😄
/cc @olizilla