Fix everything

[dignifiedquire]

• Rewrite generator code
• Add source data to the repo (data)
• Add tests for generator code
• Refactor lookup code
• Add tests for lookup code
• Generate new data and add it to the 0.3 and 0.4 network (QmRn43NNNBEibc6m7zVNcS6UusB1u3qTTfyoLmkugbeeGJ)

Fixes #6

[dignifiedquire]

Travis fails because it's not pinned on the 0.3 network probably and the resolves are too slow due to that

[daviddias]

shall we add this script as a bin script to be installed and accessible globally? :)

[dignifiedquire]

It's available as npm run generate as documented which I think is enough, but I'm okay adding it the bin scripts

[daviddias]

woooooo. Do we really want to push the dataset to the repo?

[daviddias]

Codewise LGTM :) great work @dignifiedquire !! Finally we have geoip working with proper tests and more docs :) 💃

[daviddias]

One request, if all that travis needs is to have the dataset pinned on 0.3, can we do that to see if it goes green? It will be also useful for anyone else that might want to contribute as well.

[dignifiedquire]

woooooo. Do we really want to push the dataset to the repo?

I don't know, I'd rather have it checked in than go search for it again in the future tbh

[dignifiedquire]

One request, if all that travis needs is to have the dataset pinned on 0.3, can we do that to see if it goes green? It will be also useful for anyone else that might want to contribute as well.

I want to make it green, but pinbot keeps dying when trying to pin it :(

[ghost]

I don't know, I'd rather have it checked in than go search for it again in the future tbh

Let's put it into IPFS and pin.

This dataset: ipfs.io/ipfs/<hash1>
produces this merkledag: ipfs.io/ipfs/<hash2>
Latest dataset available here: someurl.com/dataset.tgz

[jbenet]

Yes, put it into IPFS, not this repo. We should pin it.

(We should look into making a pinbot that works with github repos.)

[dignifiedquire]

@lgierth @jbenet done, all data is now on ipfs, and gets downloaded automatically when generate is run :)

[ghost]

Great 👍 could you squash the commits so that we don't bloat the repo size unneccessarily?

[dignifiedquire]

@lgierth will do. any updates on pinning location data on 0.3? pinbot always dies

[jbenet]

where did this file go? is it not needed anymore?

[dignifiedquire]

@jbenet onto ipfs

[jbenet]

@dignifiedquire would be nice to make CI pass the tests, that way merging changes is way easier / safer. fine to be a new issue + separate PR.

[dignifiedquire]

@jbenet they will pass when 0.3 has the geo data

[dignifiedquire]

Merging this for now, tests will work as soon as the 0.3 issues are resolved. But I need a new release for use in ipfs/webui.

[daviddias]

What is blocking us from pinning it on 0.3? Is there an issue in infrastructure to track that progress that can be linked from here?

[ghost]

What is blocking us from pinning it on 0.3? Is there an issue in infrastructure to track that progress that can be linked from here?

nothing -- I'm on it