Update mutable tests with new spec #6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,19 +31,25 @@ Progress: https://github.com/ipfs/community/discussions/573 | |
| - [x] Render empty directories | ||
| - [x] Resolve `index.html` in a path | ||
| - `mutable.html` Tests (experimental, some things subject to change) | ||
| - [x] JS `fetch('ipfs://<CID>/example.txt', {method: 'PUT'})` | ||
| - [x] JS `fetch('ipfs://<CID>/', {method: 'PUT', body: new FormData})` | ||
| - [x] JS `fetch('ipfs://<CID>/example.txt', {method: 'DELETE'})` | ||
| - [x] JS `fetch('ipns://<key>', {method: 'POST', body: <CID>})` | ||
| - [x] JS `fetch('ipns://<key>/example.txt', {method: 'POST', body: <CID>})` | ||
| - [x] JS `fetch('ipns://<key>', {method: 'PUT', body: file})` | ||
| - [x] JS `fetch('ipns://<key>/example', {method: 'PUT', body: file})` | ||
| - [x] JS `fetch('ipns://<key>', {method: 'PUT', body: formdata})` | ||
| - [x] JS `fetch('ipns://<key>/example', {method: 'PUT', body: formdata})` | ||
| - [x] JS `fetch('ipns://<key>/example.txt', {method: 'DELETE'})` | ||
| - [x] JS `fetch('ipns://localhost?key=<name>', {method: 'GET})` | ||
| - [x] JS `fetch('ipns://localhost?key=<name>', {method: 'DELETE})` | ||
| - `dag.html` Tests (experimental, some things subject to change) | ||
| - [x] GET `ipfs://<CID>/?format=car` | ||
| - [x] GET `ipfs://<CID>/?format=raw` | ||
| - [x] GET `ipfs://<CID>/?format=dag-json` | ||
| - [x] GET `ipfs://<CID>/?format=dag-cbor` | ||
|
Comment on lines
+47
to
+50
There was a problem hiding this comment. 💭 we should add tests with |
||
| - [x] POST `Content-Type: application/json` `?format=dag-cbor` & GET `?format=dag-cbor` | ||
| - [x] POST over existing CID to add to graph | ||
|
|
||
| ## Screenshots: | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 sending CID in the body feels weird, but I can't put my finger on why 😅
I was thinking that maybe it is squatting too much, what if one wants to do IPNS in userland, maintain keys on their own, create, sign record in JS, and then send it to
ipns://only for publishing? I believe we should make sure a primitive for doing it exists.I guess that could be represented as
POSTwithContent-Type: application/vnd.ipfs.ipns.record?