Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed lots of typos and missing spaces #950

Closed
wants to merge 1 commit into from

Conversation

alexandreleroux
Copy link

No description provided.

@olizilla
Copy link
Member

olizilla commented Feb 5, 2019

Thank you for taking the time to do this! We use Transifex to manage our translation process, the locale json files are generated from there, so these changes would be lost next time we run the build process. Would you port these fixes to https://www.transifex.com/ipfs/ipfs-webui/dashboard/ ?

This is a good indicator that we need to do more to make that clearer. We are storing the translations in the repo, to make it easier for developers to try out other locales. But we could remove them and add instructions for devs on how to fetch them on demand.

@alexandreleroux
Copy link
Author

Thanks @olizilla for the info. I have created a Transifex account and team membership for the IPFS Web UI translations. Once I get approved, I'll try to find the time to contribute back those proposed changes through Transifex.

And yes, it would be pertinent to ensure others don't so the same mistake I did by editing the copy on this repos. Thanks! :-)

@alexandreleroux
Copy link
Author

Done, fixes to translation applied on Transifex

@alexandreleroux alexandreleroux deleted the patch-1 branch February 9, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants