Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-default locales from the repo #954

Closed
olizilla opened this issue Feb 5, 2019 · 2 comments
Closed

Remove non-default locales from the repo #954

olizilla opened this issue Feb 5, 2019 · 2 comments
Assignees

Comments

@olizilla
Copy link
Member

olizilla commented Feb 5, 2019

We should remove all the locale files from the repo and and them to the .gitignore, and update the docs and run scripts to fetch them on postinstall.

Having generated artefacts in a repo always leads to trouble eventually, and in this case it sets us up to waste the time of people who volunteer to fix translation issues.

See #950

@lidel
Copy link
Member

lidel commented Feb 5, 2019

@olizilla removing locales from repo will introduce various issues. I am against mainly for two reasons:

  1. Builds are no longer reproducible in offline mode + require access to the internet and Transifex API
    • Third party web service can break our builds
    • Also, I am not sure if you can fetch locales without account on Transifex and API key in ~/.transifexrc, which complicates CI and local setups for drive-by contributors
  2. We will be getting an amazing improvement for translations soon, but it needs locales to be present in repos (added you to email thread with Transifex, tl;dr is in Transifex: Improved GitHub Integration  ipfs-shipyard/i18n#5)

To avoid people submitting PRs with translations, we could:

@lidel
Copy link
Member

lidel commented Feb 5, 2019

Also, I suggest we always close PRs that bypass Transifex (eg. #950 - should close without merging).

Gently thank for translation and ask them to apply changes via Transifex or just link to ipfs/i18n#how-can-i-contribute-translation-for-my-language

  • Example: update zh_CN ipfs-companion#658
  • Why? This creates a paper trail that future translators can discover while doing research before submiting PR. So not only informs the author of the current PR, but also people that could do similar thing in the future, but look for examples of previous PRs before creating their own.

olizilla added a commit that referenced this issue Feb 18, 2019
fixes #954

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@ghost ghost assigned olizilla Feb 18, 2019
@ghost ghost added the status/in-progress In progress label Feb 18, 2019
olizilla added a commit that referenced this issue Feb 19, 2019
- Add warning in the locales dir so folks don't edit them
- Move dev details about i18next to the docs folder
- Simplify the instructions in the readme

fixes #954


License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@ghost ghost removed the status/in-progress In progress label Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants