-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-default locales from the repo #954
Comments
@olizilla removing locales from repo will introduce various issues. I am against mainly for two reasons:
To avoid people submitting PRs with translations, we could:
|
Also, I suggest we always close PRs that bypass Transifex (eg. #950 - should close without merging). Gently thank for translation and ask them to apply changes via Transifex or just link to ipfs/i18n#how-can-i-contribute-translation-for-my-language
|
fixes #954 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
- Add warning in the locales dir so folks don't edit them - Move dev details about i18next to the docs folder - Simplify the instructions in the readme fixes #954 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
We should remove all the locale files from the repo and and them to the .gitignore, and update the docs and run scripts to fetch them on postinstall.
Having generated artefacts in a repo always leads to trouble eventually, and in this case it sets us up to waste the time of people who volunteer to fix translation issues.
See #950
The text was updated successfully, but these errors were encountered: