Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dnsaddr support in isIPFS.*multiaddr() #35

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 9, 2020

This bumps dependencies to the latest versions including js-multiaddr 8.x which shipped support for resolving /dnsaddr/ Peer addresses + adds tests for those peer addresses.

We need this to fix ipfs/ipfs-webui#1593

This bumps dependencies to the latest versions including js-multiaddr
8.x which shipped support for resolving /dnsaddr/ Peer addresses.

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel marked this pull request as ready for review November 9, 2020 21:18
@lidel lidel changed the title feat: dnsaddr support in isIPFS.peerMultiaddr() feat: dnsaddr support in isIPFS.*multiaddr() Nov 9, 2020
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidel lidel merged commit 4a4710d into master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding peer of type "/dnsaddr/foo" not supported in "Add Connection" modal
3 participants