Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat request: test that browserify bundling works fine as well. #102

Closed
daviddias opened this issue Feb 11, 2017 · 3 comments · Fixed by #737
Closed

Feat request: test that browserify bundling works fine as well. #102

daviddias opened this issue Feb 11, 2017 · 3 comments · Fixed by #737
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

No description provided.

@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Feb 11, 2017
@dignifiedquire dignifiedquire added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Mar 8, 2017
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Apr 5, 2017
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jun 20, 2017
@daviddias daviddias mentioned this issue Jul 5, 2017
Merged
25 tasks
@daviddias
Copy link
Member Author

@dignifiedquire not going into aegir.next?

@dignifiedquire
Copy link
Member

No, too much work and I don't want to delay it even longer

@daviddias daviddias mentioned this issue Jul 10, 2017
Closed
@daviddias daviddias added status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up and removed status/deferred Conscious decision to pause or backlog labels Oct 17, 2017
@victorb
Copy link
Member

victorb commented Oct 3, 2018

Commit e581c68 added some acceptance tests that currently just checks that the right files are produced in aegir-test-repo but doesn't check the content.

If we add some more checks here (right files are minified, URL to sourcemap is correct, right version got bundled etc) + add the test:acceptance into CI, I think we're pretty safe here.

@hugomrdias hugomrdias mentioned this issue Feb 23, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release v31 ipfs/aegir
3 participants
@victorb @dignifiedquire @daviddias