[WIP] Aegir@next #134

dignifiedquire · 2017-07-02T14:38:42Z

- Now uses eslint-config-aegir for rules. - Updated to the latest version of standard - Updated to the eslint@4

dignifiedquire · 2017-07-02T22:09:41Z

Progress is made:

daviddias · 2017-07-03T05:09:37Z

wooooooot! :D ❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️❤️
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

daviddias · 2017-07-03T05:10:53Z

Please make things like docs and pushing a changelog mandatory (i.e check for the Github token and fail if it is not there)

daviddias · 2017-07-03T05:11:14Z

I like the new target flags 👍

daviddias · 2017-07-05T07:47:12Z

Can the following be part of this PR:

daviddias · 2017-07-05T10:46:01Z

Can aegir become one single command instead of multiple (aegir-lint, aegir-test, etc)?

daviddias · 2017-07-05T10:46:25Z

feat: disable window in favor of self as a valid global #117

daviddias · 2017-07-05T10:47:51Z

https://github.com/ipfs/aegir/issues?q=is%3Aissue+is%3Aopen+label%3Aaegir.next :D

dignifiedquire · 2017-07-05T11:00:39Z

Can aegir become one single command instead of multiple (aegir-lint, aegir-test, etc)?

that's already the case with the new structure, it is now aegir lint instead of aegir-lint etc

daviddias · 2017-07-07T18:03:14Z

I get excited every time I get a notification that there has been a new commit in this PR :D

codecov · 2017-07-08T11:54:21Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7b6419f). Click here to learn what that means.
The diff coverage is 33.75%.

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage          ?   32.05%           
=========================================
  Files             ?       32           
  Lines             ?      418           
  Branches          ?        0           
=========================================
  Hits              ?      134           
  Misses            ?      284           
  Partials          ?        0

Impacted Files	Coverage Δ
src/config/custom.js	`100% <ø> (ø)`
src/release/push.js	`0% <ø> (ø)`
src/release/docs.js	`0% <ø> (ø)`
src/release/index.js	`0% <0%> (ø)`
src/release/github.js	`0% <0%> (ø)`
src/release/publish.js	`0% <0%> (ø)`
src/docs/build.js	`0% <0%> (ø)`
src/config/karma.conf.js	`0% <0%> (ø)`
src/coverage/providers/codecov.js	`0% <0%> (ø)`
src/release/contributors.js	`0% <0%> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6419f...d4b8c31. Read the comment docs.

daviddias · 2017-07-09T10:28:42Z

src/config/custom.js

@@ -1,5 +1,5 @@
 'use strict'

 module.exports = {
-  timeout: 80 * 1000
+  timeout: 40 * 1000


What about 5 secs and any test that needs more either should get it running below 5 secs or explicitly signal that? (and I say 5 and not 2 just because of CI vs user machines)

I have seen many many tests that take longer than 5 seconds on both CI and locally so I am not sure this will just result in tons of test manually extending the timeout, which is worse imho than setting a relative high value here

I think that is a symptom of us not having something to remind us that certain operations should be fast and/or that tests should be a unit and not a massive set of operations.

reduced to 5 seconds and we get a red flag on node tests for slow tests:

daviddias · 2017-07-11T21:07:34Z

README.md

+}
+```
+
+You can also specify `hooks.browser` and `hooks.node` if you have a different setup for browser and/or node based tests.


what about hooks.electron and hooks.cordova? Will it be easy to extend to support those runtimes as well?

if we support running tests in them yes

daviddias · 2017-07-11T21:08:11Z

README.md

+
+### Renamed binaries
+
+`aegir` is now a single binary with subcommands. While something like `aegir-test` still works, we recommend to switch to the new `aegir test` syntax.


Since this is going to be a major release, you might just want to clean all of that old code anyway :)

daviddias · 2017-07-11T21:08:23Z

README.md

+
+### Switch from Mocha to Jest
+
+Because the mocha binary was the source of many pains tests in node are now run using [Jest](https://facebook.github.io/jest/). All important features should work as before, but if you were relying on a mocha specific feature it might break now.


dignifiedquire · 2017-07-11T22:48:24Z

Status update, most of the work inside this project is done. But before we can move forward we need to fix jestjs/jest#2059 which impacts us in a strong way as most of our tests are written in this particular style that causes issues in Jest. I have started looking into this, but not figured out all details yet.

dignifiedquire · 2017-07-12T14:11:16Z

Jest work is happening here: https://github.com/dignifiedquire/jest/tree/fix/async-tests

daviddias · 2017-07-15T11:26:12Z

One thing to consider is that we keep bumping the limit of nested callbacks to 8, maybe set that as the sane default?

daviddias · 2017-08-02T00:30:26Z

When you say that docs is complete, does it include a markdown exported version to API.md?

daviddias · 2017-08-15T10:08:11Z

Checking in here. I know this PR is blocked due to jest issues. Would it be good to bring mocha again so that we can have all of the other nice things in this PR?

dignifiedquire · 2017-08-15T10:09:50Z

Would it be good to bring mocha again so that we can have all of the other nice things in this PR?

We would loose some of the nice things and one of the main issues I moved away from mocha is that it had this great issue where it couldn't be properly killed, so that issue would be partially back. Going to work on the jest pr in the next days and see if I can either get it merged or otherwise publish my fork in a way we can start using it

dignifiedquire · 2017-08-16T11:40:18Z

Merging this, this branch was open long enough

feat(eslint): extract config into its own package

61ad82a

- Now uses eslint-config-aegir for rules. - Updated to the latest version of standard - Updated to the eslint@4

dignifiedquire added the status/in-progress In progress label Jul 2, 2017

dignifiedquire added 6 commits July 2, 2017 16:47

feat(browser): use uglify-es instead of uglify-js

668f3ac

feat(deps): update chalk and webpack

f37112c

refactor(lint): new cli structure for lint command

c7ce0e6

refactor(build): new cli structure

23dde2e

refactor(test): new cli setup

00c1ddc

feat(build): add filesizes to output

7a6f30c

daviddias assigned dignifiedquire Jul 3, 2017

refactor(coverage): implement new cli structure

df671ba

refactor(release): first pass

8e7a15f

dignifiedquire added 7 commits July 7, 2017 20:05

feat: add update-notifier

fd0a6d8

chore: cleanup dependencies

97de4d1

start writing tests using jest

1d0d837

feat: coverage on travis

261c213

more tests

9790a54

refactor(config): allow for better testability

65843aa

feat(coverage): allow for multiple provider publish

a323017

feat: use different renderer on ci

c4a9924

daviddias requested a review from kumavis July 9, 2017 10:15

feat: reduce default timeout to 40s and enable it in node tests

489fbb3

daviddias reviewed Jul 9, 2017

View reviewed changes

dignifiedquire added 6 commits July 9, 2017 17:22

feat: reduce timeout and monkeypatch this.timeout

13894a4

chore: cleanup unused file

a9253b1

test(browser): add test for fixtures

7c89411

test(lint): add basic test

bc20de1

chore(fixtures): move implmentation into src folder

4b1b258

feat(release): include docs generation

07d3554

daviddias mentioned this pull request Jul 10, 2017

⚡️ v0.25.0 RELEASE 🚀 ipfs/js-ipfs#910

Closed

13 tasks

dignifiedquire changed the title ~~[WIP] Next level of ageir~~ [WIP] Aegir@next Jul 10, 2017

feat: implement hooks and fix some bugs

e0f716c

daviddias reviewed Jul 11, 2017

View reviewed changes

dignifiedquire added 4 commits August 16, 2017 13:02

drop old binary refs

7b33fc0

no more sauce labs

5802b4d

docs: update readme with better migration instructions

847805d

feat: better patch for this.timeout

d4b8c31

dignifiedquire force-pushed the next branch from dd6f548 to d4b8c31 Compare August 16, 2017 11:38

dignifiedquire merged commit 6266215 into master Aug 16, 2017

dignifiedquire deleted the next branch August 16, 2017 11:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Aegir@next #134

[WIP] Aegir@next #134

dignifiedquire commented Jul 2, 2017 •

edited

Loading

dignifiedquire commented Jul 2, 2017

daviddias commented Jul 3, 2017

daviddias commented Jul 3, 2017

daviddias commented Jul 3, 2017

daviddias commented Jul 5, 2017 •

edited by dignifiedquire

Loading

daviddias commented Jul 5, 2017 •

edited by dignifiedquire

Loading

daviddias commented Jul 5, 2017

daviddias commented Jul 5, 2017

dignifiedquire commented Jul 5, 2017

daviddias commented Jul 7, 2017

codecov bot commented Jul 8, 2017 •

edited

Loading

daviddias Jul 9, 2017

dignifiedquire Jul 9, 2017

daviddias Jul 9, 2017

dignifiedquire Jul 9, 2017

daviddias Jul 11, 2017

dignifiedquire Jul 11, 2017

daviddias Jul 11, 2017

daviddias Jul 11, 2017

dignifiedquire commented Jul 11, 2017

dignifiedquire commented Jul 12, 2017

daviddias commented Jul 15, 2017

daviddias commented Aug 2, 2017

daviddias commented Aug 15, 2017

dignifiedquire commented Aug 15, 2017

dignifiedquire commented Aug 16, 2017


		### Renamed binaries

		`aegir` is now a single binary with subcommands. While something like `aegir-test` still works, we recommend to switch to the new `aegir test` syntax.


		### Switch from Mocha to Jest

		Because the mocha binary was the source of many pains tests in node are now run using [Jest](https://facebook.github.io/jest/). All important features should work as before, but if you were relying on a mocha specific feature it might break now.

[WIP] Aegir@next #134

[WIP] Aegir@next #134

Conversation

dignifiedquire commented Jul 2, 2017 • edited Loading

dignifiedquire commented Jul 2, 2017

daviddias commented Jul 3, 2017

daviddias commented Jul 3, 2017

daviddias commented Jul 3, 2017

daviddias commented Jul 5, 2017 • edited by dignifiedquire Loading

daviddias commented Jul 5, 2017 • edited by dignifiedquire Loading

daviddias commented Jul 5, 2017

daviddias commented Jul 5, 2017

dignifiedquire commented Jul 5, 2017

daviddias commented Jul 7, 2017

codecov bot commented Jul 8, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dignifiedquire commented Jul 11, 2017

dignifiedquire commented Jul 12, 2017

daviddias commented Jul 15, 2017

daviddias commented Aug 2, 2017

daviddias commented Aug 15, 2017

dignifiedquire commented Aug 15, 2017

dignifiedquire commented Aug 16, 2017

dignifiedquire commented Jul 2, 2017 •

edited

Loading

daviddias commented Jul 5, 2017 •

edited by dignifiedquire

Loading

daviddias commented Jul 5, 2017 •

edited by dignifiedquire

Loading

codecov bot commented Jul 8, 2017 •

edited

Loading