Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont overwrite existing contributors during the contributor update task on release #444

Closed
jacobheun opened this issue Oct 10, 2019 · 0 comments · Fixed by #737
Closed

Comments

@jacobheun
Copy link
Contributor

If you manually add contributors to the respective field in package.json, if those contributors don't show up as an Author in the git logs, they are removed because aegir does a full replace based on the git logs. This is problematic for Co-Authors, because git log doesn't register them as authors.

Ideally the contributors task would pick up Co-Authors in the commit logs, but that is not easy to do at the moment via the git cli. In the interim, merging the existing list and the list from the logs would be ideal.

Ref: multiformats/js-multistream-select#54 (comment)

@hugomrdias hugomrdias mentioned this issue Feb 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant