This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
chore: fix authorship #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The API has changed from callbacks to async/await. Additionally, the use has changed. See the README for usage guidance.
* chore: update deps * chore: remove package lock
alanshaw
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the squash from #52 @alanshaw was removed from history on the merge. This corrects that by amending the commit to make him the author (as he did the async refactor ❤️) and then merging master on top of it (to avoid changing history).
This will also ensure that Aegir doesn't remove him on the next release, as the authorship change will show him in the logs. I am going to create a ticket in Aegir to avoid overwriting the existing contributors so that we can manually add folks, as Co Authors don't get picked up.