Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for depchecking typescript projects #1042

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

mpetrunic
Copy link
Contributor

@achingbrain not sure if this is too disruptive.

BREAKING CHANGE:

  • no more forwarding flags
  • no more positional arguments - cannot depcheck single file
  • won't throw an error for missing dependency if it's in devDependencies section of package.json

@BigLep
Copy link

BigLep commented Sep 2, 2022

2022-09-02 conversation: next step is that @achingbrain is going to check this out locally and see how much damage this causes.

If we don't land now, we may include in a future aegir release with other breaking changes (e.g., requiring return types). If there's a lot of pain updating, we want to handle it all in one go.

@BigLep BigLep added the P3 Low: Not priority right now label Sep 2, 2022
@hugomrdias hugomrdias removed their request for review December 12, 2022 17:53
Copy link

@tinytb tinytb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can merge this into a major release of aegir
  • this should be ok to merge now that the doc auto-gen improvement is in
  • still need to manually check with some of our projects to see that it works as expected

@achingbrain achingbrain merged commit b9f5d86 into ipfs:master Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
## [38.0.0](v37.12.1...v38.0.0) (2023-01-12)

### ⚠ BREAKING CHANGES

* - no more forwarding flags
- no more positional arguments - cannot depcheck single file
- won't throw an error for missing dependency if it's in devDependencies
section of package.json

Co-authored-by: Alex Potsides <alex@achingbrain.net>
* all functions and methods need to declare a return type

### Features

* add support for depchecking typescript projects ([#1042](#1042)) ([b9f5d86](b9f5d86))

### Dependencies

* update to new linting rules ([#1164](#1164)) ([cf77bbb](cf77bbb))
@github-actions
Copy link

🎉 This PR is included in version 38.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants