Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not enforce engines in package.json #1277

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: do not enforce engines in package.json #1277

merged 1 commit into from
May 19, 2023

Commits on May 17, 2023

  1. fix: do not enforce engines in package.json 

    The engines field causes warnings on npm but errors on yarn when the
required node version is not met.

Not all of our modules require LTS node and they are used by projects
outside of libp2p/helia/etc.

This change removes the automatic addition of an engines field to a
project's `package.json` while running the `check-project` command,
instead projects that do require a certain node version are free to
define it and deal with the breakage that subsequently occurs.

Partial revert of: #1184
Refs: #1276
    @achingbrain
    achingbrain committed May 17, 2023
    Configuration menu
    Copy the full SHA
    40d70da View commit details
    Browse the repository at this point in the history