Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: karma own reported bug with missing test.titlePath #164

Merged
merged 3 commits into from
Oct 26, 2017

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Oct 25, 2017

This issue is a patch until this PR roadhump/karma-mocha-own-reporter#3 is merged

@ghost ghost assigned dryajov Oct 25, 2017
@ghost ghost added the status/in-progress In progress label Oct 25, 2017
package.json Outdated
@@ -54,7 +54,7 @@
"karma-chrome-launcher": "^2.2.0",
"karma-firefox-launcher": "^1.0.1",
"karma-mocha": "^1.3.0",
"karma-mocha-own-reporter": "^1.1.2",
"karma-mocha-own-reporter": "git+https://github.com/dryajov/karma-mocha-own-reporter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change it, so it references a commit, to avoid any chance of accidental breakage?

@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files           6        6           
  Lines         135      135           
=======================================
  Hits          105      105           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6de20f...0f4b4c6. Read the comment docs.

@dignifiedquire dignifiedquire merged commit 9ddadf9 into master Oct 26, 2017
@dignifiedquire dignifiedquire deleted the fix/karma-own-reporter branch October 26, 2017 18:37
@ghost ghost removed the status/in-progress In progress label Oct 26, 2017
@dignifiedquire
Copy link
Member

Thanks :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants