[Making aegir smaller] Add support for pkg/pkg-bundle

[mkg20001]

This adds the missing pkg.scripts field to allow aegir to be bundled using pkg/pkg-bundle which is part of #215.
This is part of an effort to write https://github.com/mkg20001/aegir-bundle which depends on writing https://github.com/mkg20001/pkg-bundle
Note: Currently WIP, the CLI isn't working properly yet.

Commands that work:

• aegir build aegir build: Webpack worker-farm child_process error mkg20001/aegir-bundle#4
• aegir coverage aegir coverage: spawn nyc ENOENT (child_process incomplete in pkg-bundle) mkg20001/aegir-bundle#5
• aegir docs
• aegir lint-commits
• aegir lint aegir lint: cannot find 'eslint-config-standard' (module not included properly by pkg) mkg20001/aegir-bundle#6
• aegir release
• aegir test aegir test: spawn mocha ENOENT mkg20001/aegir-bundle#7

[daviddias]

Same feedback from #216 (comment) applies to this one, @mkg20001.

[mkg20001]

@diasdavid I will squash the commits once things start somehow working because currently some fixes are duplicated (for ex. the eslint fix) anyways and for now I'm just trying to make it work. I will clean the duplicate fixes later.

[mkg20001]

I don't think I'll be able to finish this alone. Most of the work is in https://github.com/mkg20001/pkg-bundle which is a fork of pkg that uses the existing bundling code to create single-file bundles, instead of node executables like pkg did and the other part of the effort goes into https://github.com/mkg20001/aegir-bundle which is handling the bundling of aegir and retrieving/executing of the bundle.
Maintaining, or rather writing it is hard as it's basically messing with node's internals. Sure, it's possible to write something like this cleanly but I simply don't have the time right now to focus on so many things and also do each of those things great.
Giving this endeavor up doesn't seem like a wise choose considering it isn't far from completion, but I don't think I can and should be the only one putting work into this.

So to make it short: Would there be any members of the IPFS team/maintainers of aegir/other people that would like to help me finish this? Remember that this might make a huge impact on installation time and performance of aegir which could make all of IPFS's contributors life easier.

[mkg20001]

// cc @ipfs/dx

[victorb]

Maintaining, or rather writing it is hard as it's basically messing with node's internals

Yeah, that doesn't sound very fun nor maintainable in the future as it'll be breaking often.

I think an easier effort right now (with maybe not the same amount of impact but at least easier to do) is to go through the top-level dependencies and try to remove the biggest ones or find other ways of installing them to reduce the disk space.

The only clear decision I will make is that the DX WG won't take ownership over this specific change as it'll be too much work at this point. Maybe there are other JS/NodeJS devs more excited about this and want to implement it?

[mkg20001]

Maintaining, or rather writing it is hard as it's basically messing with node's internals

Yeah, that doesn't sound very fun nor maintainable in the future as it'll be breaking often.

It should be noted though that https://github.com/zeit/pkg has not needed many changes in a long time and most of the changes pkg-bundle would need, would come from upstream, so rebasing and testing would be the only maintaince thing that would be necessarry to do.

considering it isn't far from completion

There is only a few bugs with the child_process transformer that prevent things such as webpack/mocha from running correctly. Once these are solved the CLI should just work. (Considering I didn't need to change a single line in aegir's code so far to get lint-commits and docs cmds to work, I don't expect this to break soon. The only changes I think will be necesarry would be to the test cmd to spawn nyc/mocha in a way that pkg-bundle could detect that the executable is inside the bundle and spawn that using the wrapper)

[hugomrdias]

old pr gonna close this, feel free to reopen