feat: support async hooks #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common use of hooks in aegir is to start and stop an ipfs node for browser tests to run against. Since they all use ipfsd-ctl and that is moving to async/await in ipfs/js-ipfsd-ctl#353 as part of ipfs/js-ipfs#1670, it would be nice to not have to mix async and callbacks in the hooks. This PR adds support for async hooks while not breaking existing callback based ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common use of hooks in aegir is to start and stop an ipfs node for browser tests to run against.
Since they all use ipfsd-ctl and that is moving to async/await in ipfs/js-ipfsd-ctl#353 as part of ipfs/js-ipfs#1670, it would be nice to not have to mix async and callbacks in the hooks.
This PR adds support for async hooks while not breaking existing callback based ones.