print coverage report

[daviddias]

This prints the coverage reports after the tests are run. Though adding it as a separate step, but that would mean tests are run twice, which can be very expensive for some of our modules that have very long tests.

Also, by printing the reports but not strictly enforcing a coverage minimum, we make devs aware of how the changes impacted the overall coverage.

What do you think?

[daviddias]

just realised I missed something, give me minutes :)

done :)

[dignifiedquire]

I'm afraid I'm not happy with this solution, if you instrument tests, the tests take often more than twice as long to run. When you are developing you need to be able to quickly run tests, without wanting the overhead of instrumentation. We can make the default for dignified-test --node be run with coverage and have another option which would be dignified-test --no-coverage to just execute the tests. But there needs to be a way to just run the mocha tests.

[daviddias]

if you instrument tests, the tests take often more than twice as long to run.

really valid point. If the impact is 2x, totally agree that we should have an option to avoid cov

We can make the default for dignified-test --node be run with coverage and have another option which would be dignified-test --no-coverage to just execute the tests. But there needs to be a way to just run the mocha tests.

Let's go with the initial idea of dignified-coverage then.

[daviddias]

dignified-coverage added :)

[daviddias]

13:40 no wait the globs for istanbul need to be the same as for mocha so it doesn't load browser.js

This is the same as https://github.com/dignifiedquire/dignified.js/blob/master/tasks/test/node.js#L12-L13

What else would you like me to add?

[dignifiedquire]

I meant make the one on l12 the same as this

[daviddias]

We instrument the src on l12 with Istanbul, and run tests with mocha. We don't need to instrument the tests folder.

[dignifiedquire]

Thanks