-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade ts to 4.1.x #689
Conversation
Actually, this might cause issues, at least with libp2p. The generated build has issues with the Event Emitter per microsoft/TypeScript#41800. This will only get in |
That got me thinking maybe we can avoid that problem by using https://www.npmjs.com/package/typed-events.ts and not have to wait for 4.2 |
Sounds good. Could you add it to libp2p/js-libp2p#831 ? |
yep i also need this to fix these
but i think this will break js-ipfs right @achingbrain ? |
Ok, let's just wait for their release (4.2) before updating our end |
This will need running over js-ipfs too, ts 4.1.3 at least broke loads of things. |
Just updates TS to 4.1.x which fixes type generation for generic class extensions