Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade ts to 4.1.x #689

Merged
merged 1 commit into from
Dec 17, 2020
Merged

feat: upgrade ts to 4.1.x #689

merged 1 commit into from
Dec 17, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Dec 10, 2020

Just updates TS to 4.1.x which fixes type generation for generic class extensions

@vasco-santos
Copy link
Member

Actually, this might cause issues, at least with libp2p. The generated build has issues with the Event Emitter per microsoft/TypeScript#41800. This will only get in 4.2

@Gozala
Copy link
Contributor Author

Gozala commented Dec 10, 2020

Actually, this might cause issues, at least with libp2p. The generated build has issues with the Event Emitter per microsoft/TypeScript#41800. This will only get in 4.2

That got me thinking maybe we can avoid that problem by using https://www.npmjs.com/package/typed-events.ts and not have to wait for 4.2

@vasco-santos
Copy link
Member

That got me thinking maybe we can avoid that problem by using https://www.npmjs.com/package/typed-events.ts and not have to wait for 4.2

Sounds good. Could you add it to libp2p/js-libp2p#831 ?
This will need a merge/rebase from 0.30 too. Perhaps better to open a new PR and copy the changes

@hugomrdias
Copy link
Member

yep i also need this to fix these

src/index.js:1:1 - error TS9006: Declaration emit for this file requires using private name 'Suffix' from module '"/Users/hd/code/pl/js-datastore-core/src/shard"'. An explicit type annotation may unblock declaration emit.

but i think this will break js-ipfs right @achingbrain ?

@vasco-santos
Copy link
Member

vasco-santos commented Dec 11, 2020

Ok, let's just wait for their release (4.2) before updating our end

@achingbrain
Copy link
Member

achingbrain commented Dec 16, 2020

This will need running over js-ipfs too, ts 4.1.3 at least broke loads of things.

@hugomrdias hugomrdias merged commit 5f55cba into master Dec 17, 2020
@hugomrdias hugomrdias deleted the feat/ts-4.1.x branch December 17, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants