Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome IPFS, the Webpage 🌐 #130

Merged
merged 10 commits into from
Jul 18, 2018
Merged

Awesome IPFS, the Webpage 🌐 #130

merged 10 commits into from
Jul 18, 2018

Conversation

victorb
Copy link
Member

@victorb victorb commented Apr 23, 2018

No description provided.

@ghost ghost assigned victorb Apr 23, 2018
@ghost ghost added the status/in-progress In progress label Apr 23, 2018
- Articles
- Discussions
- Below, after clicking category, show most popular tag within that category
and allow further filtering. (future allow multiple tags? Will be hard without JS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to clarify the intention here: we want to be able to assign multiple tags to an item, right?
Otherwise its just a "subcategory".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely, I should have added that in the example data files. Items should be able to have multiple tags, but on the website itself it'll be hard to generate static pages for every combination, but the items themselves should indeed have multiple tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that even possible without JS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias it's not impossible :) But it'll generate a lot of pages if we're gonna generate every single combination, so let's not do that. But at least we should generate listing pages for each label (singular)

items:
- title: Akasha
description: A Next-Generation Social Media Network, powered by Ethereum and embedded into IPFS
featured: true
Copy link
Member

@lidel lidel Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace an explicit featured boolean flag with a list of tags, and make featured just one of tags.
Based on tags, we can do all sorts of styling/filtering in the UI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a solid idea.

@hacdias
Copy link
Member

hacdias commented Apr 23, 2018

@victorbjelkholm @lidel do you mind if I use this branch to continue the work on moving this to a static website?

@victorb
Copy link
Member Author

victorb commented Apr 23, 2018

@hacdias sounds good 👍

@ghost ghost assigned hacdias Apr 25, 2018
@@ -0,0 +1,11 @@
title: Example Apps
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't we need this is a separate category anymore, should just be folded into apps or tools

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, yeah, I've changed that right after pushing. I didn't push the new commits yet :p Thanks for noticing though.

@victorb
Copy link
Member Author

victorb commented Jun 14, 2018

@hacdias is this ready to be reviewed and used or is missing anything so far?

@hacdias
Copy link
Member

hacdias commented Jun 16, 2018

@victorbjelkholm I haven't been focusing much on this yet because my exames aren't over yet. This is on my todo list after this week 😄

@hacdias
Copy link
Member

hacdias commented Jul 12, 2018

Hello! Finally back here. I was thinking and I'd like to suggest something much "simpler" than what we've been doing here. I'll try to do a sample and then show it to you

@hacdias

This comment has been minimized.

@hacdias

This comment has been minimized.

@hacdias

This comment has been minimized.

@hacdias
Copy link
Member

hacdias commented Jul 12, 2018

@lidel @victorbjelkholm so I kind of ran away from what we had defined on moving-to-hugo.md and tried something else with React and came up with this:

ipfs io_ipfs_qmqiexdkrtcdkawlbqdhjc9hyskpuzgd6mq9yyarvklw7j_

The search feature uses lunr.js which is kind of powerful. The interface's also nice on mobile phones 😄

Try it:

https://ipfs.io/ipfs/QmQiexdkRtcdkAWLBQdhJc9hYSkpUzGD6MQ9yYARVkLW7j/

If you agree with this, I can update CONTRIBUTING.md to comply with this changes 😄 and eventually remove the moving-to-hugo.md if it makes sense.

@hacdias
Copy link
Member

hacdias commented Jul 13, 2018

So, after talking yesterday with @victorbjelkholm, I tried now moving this to Hugo in order to support people that don't have JavaScript enabled and here are some screenshots for the navbar preview (choose the one you like most):

https://usercontent.irccloud-cdn.com/file/7inlllzx/localhost_1313_.png
https://usercontent.irccloud-cdn.com/file/wI8qbpRL/localhost_1313_%20(1).png
https://usercontent.irccloud-cdn.com/file/gTxuM4j1/localhost_1313_%20(2).png
https://usercontent.irccloud-cdn.com/file/wI8qbpRL/localhost_1313_%20(3).png

I haven't pushed the code yet to this repository because I'd like to make sure that it is worth it. Moving this to Hugo to have multiple pages, one for each category, increases a lot the build process and what are the benefits? The search supports filtering for each type with type:apps or type:tools already. Do we really need to have one page for each category?

Another question: do we really need to support people not using JS? We could just have a beautiful message telling the person to activate JS.

Lunrjs (the search engine), gives us scores for each card based on what we've searched for. That way we can show the most relevant results first. With React, it is easy to display the results by that order. Without React, I'm just hiding and displaying cards because it would be much difficult to be changing the order of the elements.

Need feedback @victorbjelkholm @lidel

@victorb
Copy link
Member Author

victorb commented Jul 13, 2018

Hugo handles building thousands of pages without any troubles in terms of performance so should not be a blocker for us.

The point of having one page per category is together with the "do we need JS here" question as well.

So, the reason for having a static website built with Hugo is not to necessary support people who run without JS enabled (since that audience is like 1% [guessing here...]) but rather to build interactive websites where it makes sense, and not by default. Rather than asking "Why not use JS here?" I prefer to think "Why would this be using JS?". It's just a list of links in the end!

I have no issue of doing the search with JS, the other options are building pages for every search query (yeah, right...) or having a backend, none of those are a option, so it makes sense to use JS for it.

To just show a list of links, I don't think it makes sense to use JS.

@hacdias
Copy link
Member

hacdias commented Jul 13, 2018

Okay, so let's stick with Hugo. I'll make some changes on the JS to make the scoring from Lunr.js be taking in account.

What about the navbar, which one did you like most? @victorbjelkholm

@lidel
Copy link
Member

lidel commented Jul 13, 2018

❤️ the search and filtering feature!

Some thoughts:

  • I don't have strong opinions about navbar, all versions are fine, but *(2).png strikes a good balance: feels light, does not take much viewport and does not steal too much focus from the content itself.
  • Making it JS-only is problematic accessibility-wise:
  • Do we really need to have one page for each category?

    • I think a minimum of what we want are permalinks for categories 🔗
      For non-JS version it should be enough to be able to link to a specific section, which is possible right now with markdown and github: #apps or #tools

@hacdias
Copy link
Member

hacdias commented Jul 13, 2018

@lidel I'll make the needed updates to add the navbar and soon you'll be all able to try. 😄

@hacdias
Copy link
Member

hacdias commented Jul 13, 2018

@lidel
Copy link
Member

lidel commented Jul 13, 2018

Niice, non-JS version has it all now 👌

One nitpick:

  • Clicking on "Awesome IPFS" should navigate to main page with all categories (right now if you are in /categories/articles/ it re-opens current category).

@hacdias

This comment has been minimized.

@hacdias hacdias force-pushed the static-site branch 2 times, most recently from 9a1cede to 6b98306 Compare July 14, 2018 12:59
@hacdias
Copy link
Member

hacdias commented Jul 14, 2018

https://ipfs.io/ipfs/QmWQfXaTdUAEhhj5PGyezDQSN26Smbf6hRTQYgY59Q7Byp/

@hacdias
Copy link
Member

hacdias commented Jul 18, 2018

Now the elements are displayed on a random order every time we open the page. /cc @lidel

@hacdias
Copy link
Member

hacdias commented Jul 18, 2018

I think this is finished. Unless you find sometime to improve or to change, it's done.

/cc @victorbjelkholm @lidel @diasdavid @olizilla

@hacdias
Copy link
Member

hacdias commented Jul 18, 2018

Maybe we can now remove the migrate-to-hugo.md file and merge this?

@victorb
Copy link
Member Author

victorb commented Jul 18, 2018

Now the elements are displayed on a random order every time we open the page

Not sure about this, I think we should probably order by date added (most recent first) but show ones with "featured" label first. But, we can change this in the future.

For now, let's merge this and open up anything we'd like to change in new issues.

Maybe we can now remove the migrate-to-hugo.md file and merge this?

I'll open up issues for the things that are missing from that, then remove it from master.

@victorb victorb merged commit 9f0bbeb into master Jul 18, 2018
@ghost ghost removed the status/in-progress In progress label Jul 18, 2018
@hacdias hacdias deleted the static-site branch July 18, 2018 09:38
@hacdias
Copy link
Member

hacdias commented Jul 18, 2018

Thanksss!!! Should we remove disable_publish from Jenkinsfile? 😄

@victorb
Copy link
Member Author

victorb commented Jul 18, 2018

@hacdias let's leave it like this for now, will modify once dns + certs are ready for it :)

@hacdias
Copy link
Member

hacdias commented Jul 18, 2018

Cool!

@flyingzumwalt
Copy link

@hacdias this is really awesome. Multiple people have said that we need it. It's great to see you taking the initiative to just build it and ship it. The rendered page looks great. Wonderful work, and thanks to @victorbjelkholm and @olizilla for helping make it even better.

@hacdias
Copy link
Member

hacdias commented Jul 18, 2018

Thanks @flyingzumwalt 😃

@akrych
Copy link

akrych commented Jul 18, 2018

@hacdias Wow! This looks great! 🥇 Thx for your hard work!

Just an idea - maybe we can add animation filtering like here: https://www.queness.com/resources/html/simple-portfolio-page/index.html

@daviddias
Copy link
Member


AWESOME WORK! Congratz!! 👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽

@daviddias
Copy link
Member

@victorbjelkholm awesome.ipfs.io isn't resolving

@daviddias
Copy link
Member

Ah, I see -- #130 (comment). Can we get it asap? :)

@hacdias
Copy link
Member

hacdias commented Jul 19, 2018

@hacdias Wow! This looks great! 🥇 Thx for your hard work!
Just an idea - maybe we can add animation filtering like here: queness.com/resources/html/simple-portfolio-page/index.html

Thanks @akrych 😄 I'll see if I can do that soon! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants