fix: rename to protocolsAllowed for readability

ipfs · Sep 25, 2024 · 51f200a · 51f200a
1 parent 9811e83
commit 51f200a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/routing/http/server/filters.go b/routing/http/server/filters.go
@@ -107,7 +107,7 @@ func applyFilters(provider *types.PeerRecord, filterAddrs, filterProtocols []str
 		return provider
 	}
 
-	if !applyProtocolFilter(provider.Protocols, filterProtocols) {
+	if !protocolsAllowed(provider.Protocols, filterProtocols) {
 		// If the provider doesn't match any of the passed protocols, the provider is omitted from the response.
 		return nil
 	}
@@ -177,7 +177,8 @@ func containsProtocol(protos []multiaddr.Protocol, proto multiaddr.Protocol) boo
 	return false
 }
 
-func applyProtocolFilter(peerProtocols []string, filterProtocols []string) bool {
+// protocolsAllowed returns true if the peerProtocols are allowed by the filter protocols.
+func protocolsAllowed(peerProtocols []string, filterProtocols []string) bool {
 	if len(filterProtocols) == 0 {
 		// If no filter is passed, do not filter
 		return true

diff --git a/routing/http/server/filters_test.go b/routing/http/server/filters_test.go
@@ -121,7 +121,7 @@ func TestApplyAddrFilter(t *testing.T) {
 	}
 }
 
-func TestApplyProtocolFilter(t *testing.T) {
+func TestProtocolsAllowed(t *testing.T) {
 	testCases := []struct {
 		name            string
 		peerProtocols   []string
@@ -174,7 +174,7 @@ func TestApplyProtocolFilter(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			result := applyProtocolFilter(tc.peerProtocols, tc.filterProtocols)
+			result := protocolsAllowed(tc.peerProtocols, tc.filterProtocols)
 			assert.Equal(t, tc.expected, result, "Unexpected result for test case: %s", tc.name)
 		})
 	}