-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add UnixFS file download over Bitswap #143
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 29.19% 29.52% +0.32%
==========================================
Files 96 100 +4
Lines 11018 11237 +219
==========================================
+ Hits 3217 3318 +101
- Misses 7448 7548 +100
- Partials 353 371 +18
|
66c0391
to
643e458
Compare
955e63e
to
ddc9f7d
Compare
b36cd9c
to
bb7af5f
Compare
bb7af5f
to
8204d32
Compare
8204d32
to
0f75aa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this PR once the remanning dependency conflicts are solved. I agree that there is a lot of complexity and I think that is something we should work on by creating helper functions for common use-cases.
0f75aa8
to
3f756da
Compare
This is a starting point to discuss how we want to manage our examples for go-libipfs. It also IMO gives some illustration on some of the UX pains of working with the existing libraries, places where we can add nicer Go helper utilities, etc.