generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add consumer migration tool #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
reviewed
Mar 27, 2023
This CLI tool rewrites Go source files to change import paths from archived repos to their new locations in go-libipfs. This really only works seamlessly if the code has not been refactored since being moved into go-libipfs.
Cases like this "github.com/ipfs/go-unixfsnode" would match "github.com/ipfs/go-unixfs" because the prefix match. This now properly checks that this ends properly.
This is for files that use `package packagename_test` to declare a segregated test package in the same folder.
Jorropo
requested changes
Mar 27, 2023
guseggert
force-pushed
the
feat/consumer-migration-tool
branch
from
March 27, 2023 20:18
9e95279
to
0882510
Compare
This is to minimize the dependencies that are introduced by the CLI, such as urfave/cli/v2 which is not necessary for boxo as a library.
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 48.11% 48.27% +0.15%
==========================================
Files 267 267
Lines 32583 32583
==========================================
+ Hits 15677 15729 +52
+ Misses 15241 15201 -40
+ Partials 1665 1653 -12 |
guseggert
force-pushed
the
feat/consumer-migration-tool
branch
from
March 27, 2023 20:55
fd9d322
to
4392089
Compare
Jorropo
approved these changes
Mar 27, 2023
guseggert
force-pushed
the
feat/consumer-migration-tool
branch
from
March 27, 2023 21:20
4392089
to
2ff161f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.