Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add gateway-conformance tests for car-gateway #237

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 30, 2023

This PR adds https://github.com/ipfs/gateway-conformance tests for CAR gateway example.

Note that subdomain-gateway spec is currently disabled in the gateway-conformance suite.

@galargh galargh requested review from laurentsenta and hacdias March 30, 2023 15:43
@galargh galargh requested a review from a team as a code owner March 30, 2023 15:43
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #237 (16cc265) into main (6f324be) will increase coverage by 0.29%.
The diff coverage is 63.63%.

❗ Current head 16cc265 differs from pull request most recent head 1c5519c. Consider uploading reports for the commit 1c5519c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   47.70%   48.00%   +0.29%     
==========================================
  Files         266      269       +3     
  Lines       32950    32986      +36     
==========================================
+ Hits        15718    15834     +116     
+ Misses      15549    15491      -58     
+ Partials     1683     1661      -22     
Impacted Files Coverage Δ
examples/gateway/common/blocks.go 82.60% <63.63%> (-17.40%) ⬇️

... and 19 files with indirect coverage changes

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will be merging this. I'm investigating the subdomain in #246. It's probably similar to the issues we had in Bifrost (ipfs-inactive/bifrost-gateway#66), but I think there's something else too. Again, thanks @galargh @laurentsenta for your work on this!

@hacdias hacdias merged commit b01359c into main Mar 31, 2023
@hacdias hacdias deleted the ci/gateway-conformance branch March 31, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants