Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): allow CAR trustless requests with path #358

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jun 19, 2023

Fixes #356.

@hacdias hacdias requested a review from lidel as a code owner June 19, 2023 07:40
@hacdias hacdias self-assigned this Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #358 (4530557) into main (abc4d0c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   50.63%   50.68%   +0.04%     
==========================================
  Files         281      281              
  Lines       34043    34043              
==========================================
+ Hits        17237    17253      +16     
+ Misses      15015    15004      -11     
+ Partials     1791     1786       -5     
Impacted Files Coverage Δ
gateway/handler.go 71.35% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias and @hannahhoward for catching this.
Lgtm, but needs regression test mentioned below.

gateway/handler.go Show resolved Hide resolved
@lidel lidel mentioned this pull request Jun 19, 2023
@lidel lidel merged commit cd67d2d into main Jun 19, 2023
@lidel lidel deleted the issue/356 branch June 19, 2023 11:51
@BigLep BigLep mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Trustless Gateway mode rejects CAR requests allowed under IPIP-402
2 participants