Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap: reenable tests #423

Merged
merged 2 commits into from
Aug 25, 2023
Merged

bitswap: reenable tests #423

merged 2 commits into from
Aug 25, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 3, 2023

I need to run in CI to see whats failing.

Updates #327

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #423 (2a774cb) into main (303595b) will increase coverage by 5.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   61.23%   66.30%   +5.07%     
==========================================
  Files         205      202       -3     
  Lines       24399    24328      -71     
==========================================
+ Hits        14940    16130    +1190     
+ Misses       8015     6786    -1229     
+ Partials     1444     1412      -32     

see 40 files with indirect coverage changes

This only enable tests that weren't always failing on CI.
@Jorropo Jorropo force-pushed the bitswap/tests branch 2 times, most recently from 7a3a55d to f2444d4 Compare August 25, 2023 10:42
@Jorropo Jorropo marked this pull request as ready for review August 25, 2023 11:23
@Jorropo Jorropo requested a review from a team as a code owner August 25, 2023 11:23
@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 25, 2023

Remaining elements:

bitswap/client/internal/messagequeue/messagequeue_test.go:223:  test.Flaky(t)
bitswap/client/internal/messagequeue/messagequeue_test.go:246:  test.Flaky(t)
bitswap/client/internal/session/session_test.go:365:    test.Flaky(t)
provider/internal/queue/queue_test.go:41:       test.Flaky(t)
provider/internal/queue/queue_test.go:59:       test.Flaky(t)
provider/internal/queue/queue_test.go:85:       test.Flaky(t)
provider/internal/queue/queue_test.go:108:      test.Flaky(t)
provider/reprovider_test.go:185:                test.Flaky(t

@Jorropo Jorropo merged commit c135968 into main Aug 25, 2023
13 checks passed
@Jorropo Jorropo deleted the bitswap/tests branch August 25, 2023 11:26
@rvagg
Copy link
Member

rvagg commented Aug 28, 2023

well done, that's a lot of tests reenabled 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants