fix(gw): blocked content produces http error 410 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Codecov Report
@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 65.82% 65.92% +0.09%
==========================================
Files 206 206
Lines 25372 25378 +6
==========================================
+ Hits 16702 16731 +29
+ Misses 7196 7180 -16
+ Partials 1474 1467 -7
|
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Oct 28, 2023
this is the minimum we need right now to make content blocking from ipfs/kubo#10161 return HTTP 410 on rule match
lidel
force-pushed
the
fix/gw-error-content-block
branch
from
72da286
to
182e86f
Compare
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Oct 28, 2023
requires ipfs/boxo#497 which is based on top of the boxo already used in kubo master to avoid issues caused by ilater commits in boxo main
|
I'm merging this to have 182e86f in main boxo branch directly after a50f784. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quick and dirty minimum we need right now to make content blocking from ipfs/kubo#10161 return HTTP 410 on rule match, and have tests that guard this pass.
kubo/test/cli/content_blocking_test.go(feat: built-in content blocking based on IPIP-383 kubo#10161)