bitswap/network: split Routing in two in interface #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does nothing, the reason it exists is because two different branches want to independently remove methods from this interface, this decouple the two methods allowing to do so without git conflicts.
This was referenced Feb 16, 2024
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #580 +/- ##
==========================================
- Coverage 65.56% 65.34% -0.22%
==========================================
Files 207 204 -3
Lines 25597 25526 -71
==========================================
- Hits 16782 16680 -102
- Misses 7336 7362 +26
- Partials 1479 1484 +5 |
|
Forget this, that doesn't help since then it has conflicts on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does nothing, the reason it exists is because two different branches want to independently remove methods from this interface, this decouple the two methods allowing to do so without git conflicts.