Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add protocol and address filtering to delegated routing api #678

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

2color
Copy link
Member

@2color 2color commented Oct 1, 2024

What's in this PR

  • Adds client protocol and address filtering according to IPIP-484 to the HTTP Client

Notes

  • Since not all delegated routing servers support IPIP-484, e.g. IPNI, client side filtering is enabled by default, and needs to be disabled with WithDisabledLocalFiltering

@2color 2color requested a review from a team as a code owner October 1, 2024 07:48
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 20 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (19a402b) to head (d45e9df).

Files with missing lines Patch % Lines
routing/http/client/client.go 62.06% 11 Missing ⚠️
routing/http/filters/filters.go 73.52% 6 Missing and 3 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   60.36%   60.35%   -0.01%     
==========================================
  Files         243      243              
  Lines       30953    30998      +45     
==========================================
+ Hits        18684    18710      +26     
- Misses      10612    10624      +12     
- Partials     1657     1664       +7     
Files with missing lines Coverage Δ
routing/http/server/server.go 73.16% <100.00%> (+0.49%) ⬆️
routing/http/filters/filters.go 82.51% <73.52%> (ø)
routing/http/client/client.go 71.95% <62.06%> (-1.06%) ⬇️

... and 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant