Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitswap/client/providerquerymanager): use non-timed out context for tracing #721

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Nov 14, 2024

@gammazero going to test this out, but this seems like a relatively simple fix to the issue where we cancel the context which stops the tracing. Instead we pass the uncancelled context from the parent.

Note: I skipped the changelog since it seems like a fairly minor change, but can add if you think it makes sense

@aschmahmann aschmahmann requested a review from a team as a code owner November 14, 2024 21:39
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (625aadd) to head (e11bbf9).
Report is 5 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   60.38%   60.38%           
=======================================
  Files         243      243           
  Lines       31021    31021           
=======================================
+ Hits        18731    18732    +1     
+ Misses      10626    10624    -2     
- Partials     1664     1665    +1     
Files with missing lines Coverage Δ
...ernal/providerquerymanager/providerquerymanager.go 89.73% <ø> (+0.76%) ⬆️

... and 11 files with indirect coverage changes


🚨 Try these New Features:

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see one missing item in the trace, but this is better.

@gammazero gammazero merged commit 13d0b32 into main Nov 19, 2024
16 of 17 checks passed
@gammazero gammazero deleted the fix/pqm-context-tracing branch November 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants