Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final copy edits #120

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Final copy edits #120

merged 1 commit into from
Apr 20, 2016

Conversation

RichardLitt
Copy link
Member

@jbenet jbenet added the status/in-progress In progress label Apr 20, 2016
@daviddias
Copy link
Member

LGTM :)

dignifiedquire
dignifiedquire reviewed Apr 20, 2016
View reviewed changes
js-project-guidelines.md
@@ -195,7 +203,7 @@ after_success:
##### `.gitignore`

To avoid checking in unwanted files, the `.gitignore` file should follow
this [example](examples/.gitignore).
the [example](examples/.gitignore). This is if you are using `aegir` - smaller projects can use smaller .gitignore files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing backticks on gitignore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@RichardLitt RichardLitt merged commit f293fc3 into update/js-project-guidelines Apr 20, 2016
@jbenet jbenet removed the status/in-progress In progress label Apr 20, 2016
@RichardLitt RichardLitt deleted the feature/final-edits-maybe branch April 20, 2016 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichardLitt @daviddias @dignifiedquire @jbenet