docs: Update CONTRIBUTING_JS.md #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates contributing doc to remove references to obsolete tools, add references to Unified CI and clarify supported platforms
BigLep
reviewed
May 24, 2023
There was a problem hiding this comment.
Thanks for updating this. It's a good/useful doc.
Other things coming to mind: conventions around docs for generating table of contents. Maybe point at suggested extensions to help do this.
I left some other comments, but feel free to merge without me looking again.
|
Bump for @achingbrain to resolve any open questions and merge when ready. |
Co-authored-by: Steve Loeppky <biglep@protocol.ai> Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates contributing doc to remove references to obsolete tools, add references to Unified CI and clarify supported platforms
Refs: ipfs/helia#113