fix: switch to new dnslink updater #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/dnslink-updater
branch
from
ceb4689 to
dcc92ac
Compare
|
This change produced no new differences in built artifacts. |
lidel
force-pushed
the
fix/dnslink-updater
branch
from
dcc92ac to
7009472
Compare
lidel
commented
Nov 8, 2023
Comment on lines
+154
to
+155
| go install github.com/ipfs/dnslink-dnsimple@v0.1.0 | ||
| dnslink-dnsimple --domain dist.ipfs.tech --record _dnslink --link /ipfs/${{ steps.cid-reader.outputs.CID }} |
There was a problem hiding this comment.
ℹ️ dnslink update is now simplified to this
|
This change produced no new differences in built artifacts. |
lidel
commented
Nov 8, 2023
| @@ -91,7 +91,7 @@ async function addFiles (localPath) { | |||
| const patchRoot = await addFiles(PATCH_SRC) | |||
| console.log(`Patch root is ${patchRoot}`) | |||
|
|
|||
| const distRoot = await ipfs.dns(DIST_DOMAIN) | |||
There was a problem hiding this comment.
ℹ️ dns is deprecated, switching to resolve avoids having to deal with bug described in ipfs/kubo#10212
|
@hacdias if this looks ok feel free to merge. |
lidel
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Nov 9, 2023
This solves problem described in ipfs/distributions#1053 by switching to new tool like we did in ipfs/distributions#1055
hacdias
approved these changes
Nov 9, 2023
lidel
added a commit
to ipfs/ipfs-webui
that referenced
this pull request
Nov 9, 2023
This solves problem described in ipfs/distributions#1053 by switching to new tool like we did in ipfs/distributions#1055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1053 by switching from old JS tool to newly fixed (ipfs-shipyard/dnslink-dnsimple#21) GO one (kudos to @ns4plabs).
We will no longer update
.ioversion, as it will be CNAMEd to_dnslink.dist.ipfs.techinstead.TODO
dnslink-dnsimple@v0.1.0(go) locally with temporary tokendnslink-dnsimple@v0.1.0(go) tool_dnslink.dist.ipfs.ioto point at_dnslink.dist.ipfs.techso we only need to update .tech from now