[WIP] Front end II #19
Conversation
| ``` | ||
|
|
||
|
|
||
| ## How this repo works |
There was a problem hiding this comment.
why was this moved here? let's keep all of this in the README.md -- the readme of this repo viewed from github should make it very clear how to use the repo. people won't click on CONTRIBUTING.md even if we link to it.
There was a problem hiding this comment.
This is a work in progress as stated in the title, I moved it out of the way because it needs to be rewritten and updated as it is not up to date anymore. Also details about what tech is used etc, do not belong in the main readme, just quick instructions on how to get things up and running.
|
@dignifiedquire most of this LGTM, except for the dependencies problem. |
| {"id": "arm", "name": "ARM", "browser": "ARM"} | ||
| ] | ||
| } |
There was a problem hiding this comment.
i seem to recall a reason this was in mkdist and not here (i had to move it out after finding a problem) but i don't recall why...
There was a problem hiding this comment.
one thing to note: not all OSes and platforms listed here will be present in a release. these are just the ones that it normally would be, from which to check. maybe this is why i had it in mkdist, and why the concat below is now likely wrong.
There was a problem hiding this comment.
Yes I'm not entirely happy with having to replicate this list in every dist/* folder. But need to see more different dists to find a good solution for this.
| @@ -80,7 +80,7 @@ dist_version() { | |||
|
|
|||
| # generate dist.json file | |||
| echo "---> generating dist.json" | |||
| ./mkdist.js "$version" | |||
| `which node` ./mkdist.js "$version" | |||
There was a problem hiding this comment.
I know this doesn't solve the issues, but just want to pull it out, and make clear it's js file getting executed via node
|
All merged into #15 |
ghost
deleted the
Solve all the issues in #18