Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nopfs plugin builds (DNM) #857

Closed
wants to merge 6 commits into from
Closed

Nopfs plugin builds (DNM) #857

wants to merge 6 commits into from

Commits on Jun 13, 2023

  1. Support plugin builds

    Placing a "plugin" file in the `dists/<repo>` folder will trigger a
    -buildmode=plugin build using CGO.
    hsanjuan committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    45c6494 View commit details
    Browse the repository at this point in the history
  2. Add builds for nopfs

    hsanjuan committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4a6b693 View commit details
    Browse the repository at this point in the history
  3. Build only linux/amd64

    hsanjuan committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ab6b652 View commit details
    Browse the repository at this point in the history
  4. Use new current version

    hsanjuan committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ea263b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. build v0.21.0-rc2

    hsanjuan committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5d59ac6 View commit details
    Browse the repository at this point in the history
  2. Fix: use actual repo/package/version to do go mod init

    The build process:
    
      * Sets a custom GOPATH
      * Clones the repo we want to build inside it
      * Does a go mod init and requires the repository we want to build directly (ignoring submodules) by doing a "rev-parse HEAD" on what we cloned
      * Then go-builds the package "go build [...] -mod=mod my.package/abc.
    
    I'm not sure why -mod=mod is updated, but this automatically updates the
    go.mod when working with submodules (sub-packages) that are tagged separately,
    to the point that it uses wrong releases (not the checked out one).
    
    This has not been noticed in 4 years because we usually build the last tagged
    version of things. It you attempt to build a submodule with their own tag
    while using a tag that is not the latest it will start misbehaving.
    
    This attempts to require exactly what we are trying to build in the go.mod file.
    hsanjuan committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4d798ab View commit details
    Browse the repository at this point in the history