Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration 8-9 - Encoding key filenames with base32 #96

Merged
merged 12 commits into from
Mar 17, 2020

Conversation

hsanjuan
Copy link
Contributor

Continue work from #84 .

More context at ipfs/kubo#6012

License: MIT
Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
@hsanjuan hsanjuan changed the title Migration 7-8 - Encoding key filenames with base32 Migration 8-9 - Encoding key filenames with base32 Feb 28, 2020
Copy link
Contributor Author

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Tests are missing altogether.

ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
ipfs-8-to-9/migration/migration.go Outdated Show resolved Hide resolved
@hsanjuan hsanjuan force-pushed the migration/8-base32_encoded_keys branch from b75f9c5 to 111d678 Compare March 5, 2020 20:31
@hsanjuan hsanjuan force-pushed the migration/8-base32_encoded_keys branch from d7b1711 to 31f3081 Compare March 5, 2020 20:41
@hsanjuan hsanjuan requested a review from Stebalien March 5, 2020 20:46
@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 5, 2020

@Stebalien so this is more or less ready:

ipfs/kubo#6955 is ready

The migration is ready and has some tests (which also touch the previous bootstrappers migration).

@Stebalien Stebalien merged commit 40917c0 into master Mar 17, 2020
@Stebalien Stebalien deleted the migration/8-base32_encoded_keys branch March 17, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants