-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration 8-9 - Encoding key filenames with base32 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
hsanjuan
changed the title
Migration 7-8 - Encoding key filenames with base32
Migration 8-9 - Encoding key filenames with base32
Feb 28, 2020
hsanjuan
commented
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Tests are missing altogether.
hsanjuan
force-pushed
the
migration/8-base32_encoded_keys
branch
from
March 5, 2020 20:31
b75f9c5
to
111d678
Compare
hsanjuan
force-pushed
the
migration/8-base32_encoded_keys
branch
from
March 5, 2020 20:41
d7b1711
to
31f3081
Compare
@Stebalien so this is more or less ready: ipfs/kubo#6955 is ready The migration is ready and has some tests (which also touch the previous bootstrappers migration). |
Stebalien
requested changes
Mar 16, 2020
Stebalien
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue work from #84 .
More context at ipfs/kubo#6012