Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: document usage #102

Merged
merged 2 commits into from
Jun 30, 2023
Merged

README: document usage #102

merged 2 commits into from
Jun 30, 2023

Conversation

laurentsenta
Copy link
Contributor

Contributes to #8

@laurentsenta laurentsenta requested review from galargh and hacdias June 30, 2023 13:00
@laurentsenta
Copy link
Contributor Author

@hacdias you've been working on the test suite as well, you might have feedback about this :)

Makefile Outdated
Comment on lines 8 to 11
./gateway-conformance test --verbose --json reports/output.json --gateway-url http://127.0.0.1:8080 --subdomain-url http://example.com:8080

test-kubo: provision-kubo gateway-conformance
./gateway-conformance test --json reports/output.json --gateway-url http://127.0.0.1:8080 --specs -subdomain-gateway
./gateway-conformance test --verbose --json reports/output.json --gateway-url http://127.0.0.1:8080 --specs -subdomain-gateway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make verbose output the default? By this point it's a loooooot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion here, reverted!

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good starting point and addition to the README. In my personal case, I usually already have everything configured - as I usually also create the fixtures -, so my process is often different 😅

@laurentsenta laurentsenta requested a review from galargh June 30, 2023 14:08
@laurentsenta laurentsenta merged commit 7baa3b9 into main Jun 30, 2023
@laurentsenta laurentsenta deleted the doc/usage branch June 30, 2023 14:29
@laurentsenta laurentsenta mentioned this pull request Jun 30, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants