Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: with specs dashboard #163

Merged
merged 7 commits into from
Sep 15, 2023
Merged

feat: with specs dashboard #163

merged 7 commits into from
Sep 15, 2023

Conversation

laurentsenta
Copy link
Contributor

@laurentsenta laurentsenta commented Sep 13, 2023

Contributes to #123

Introduce specs dashboard side.

Example in https://singulargarden.github.io/gateway-conformance/specs/
We preserve the structure passed from specs.ipfs.tech to make linking and navigation easier.

For example:
https://singulargarden.github.io/gateway-conformance/specs/http-gateways/trustless-gateway/#entity-bytes-request-query-parameter

  • process the specs and render the specs/a/b/c/ pages
  • render the dashboard for each specs, and the #sub-spec-by-hash
  • Add https:// to the specs URL + add Specs field for multiple specs
  • Create spec -> tests & tests -> spec indexes

Note:

Tests are trees: TestDagSomething/GET_Something/StatusCode
And specs are also trees: http-gateways/trustless-gateway/#entity-bytes-request-query-parameter
What do you render for the spec http-gateways/trustless-gateway, especially if no tests are linking to that specific node in the tree?
The current PR renders all of its children, we'll have to refine this in further PRs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1853 11 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1853 0 0 0

@laurentsenta laurentsenta merged commit e8caf27 into main Sep 15, 2023
13 of 15 checks passed
@laurentsenta laurentsenta deleted the feat-with-specs-dashboard branch September 15, 2023 09:25
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant