Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add hsanjuan to kubo maintainers #213

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: add hsanjuan to kubo maintainers #213

merged 2 commits into from
Nov 15, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 15, 2024

Summary

  • adding @hsanjuan to @ipfs/kubo-maintainers as well
  • adding @ipfs/shipyard as maintainer in places where we only has @ipfs/kubo-maintainers and lowering permissions of wider @ipfs/shipyard group from "admin" to "maintain"

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@lidel lidel requested review from a team as code owners November 15, 2024 13:34
@lidel lidel requested a review from laurentsenta November 15, 2024 13:34
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User 2color:
  - will have the permission to go-test change from admin to maintain
User guillaumemichel:
  - will have the permission to go-test change from admin to maintain
  - will gain maintain permission to ipfs-check
User hsanjuan:
  - will have the permission to boxo change from maintain to admin
  - will have the permission to kubo change from maintain to admin
  - will have the permission to rainbow change from maintain to admin
  - will have the permission to someguy change from maintain to admin
User jorropo:
  - will have the permission to go-test change from admin to maintain
User marcopolo:
  - will have the permission to go-test change from admin to maintain
  - will gain maintain permission to ipfs-check
User sgtpooki:
  - will have the permission to go-test change from admin to maintain
  - will gain maintain permission to ipfs-check

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_team_membership.this["kubo maintainers:hsanjuan"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "6744049"
      + username = "hsanjuan"
    }

  # github_team_repository.this["shipyard:go-test"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "go-test"
      + team_id    = "11478581"
    }

  # github_team_repository.this["shipyard:ipfs-check"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "ipfs-check"
      + team_id    = "11478581"
    }

  # github_team_repository.this["w3dt-stewards:go-test"] will be updated in-place
  ~ resource "github_team_repository" "this" {
        id         = "4656983:go-test"
      ~ permission = "admin" -> "maintain"
        # (3 unchanged attributes hidden)
    }

Plan: 3 to add, 1 to change, 0 to destroy.

@lidel lidel merged commit 788df54 into master Nov 15, 2024
6 checks passed
@lidel lidel deleted the add-hsanjuan-to-kubo branch November 15, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant