-
Notifications
You must be signed in to change notification settings - Fork 112
Conversation
WireTap interface can be used to access all messages send and received by Bitswap. This can be used to implement advanced statistics/analysis logic, which is beyond scope of Bitswap, but can be implemented as IPFS plugin. Some examples of potential applications: - per CID bandwidth tracker (see: https://gitcoin.co/issue/PinataCloud/apollo/2/100023631) - detailed per peer stats - intrusion detection system (IDS) implementation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Hello, this PR looks good 👍 Could you please create a very simple test that just sends and receives a few messages between two nodes and verifies that You can probably copy part of TestBasicBitswap |
@dirkmc thanks for pointing me to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! 👍
It looks like the tests never ran. I wonder if CircleCI doesn't run for users without commit access? |
Fixed in #446. |
WireTap interface can be used to access all messages send and received
by Bitswap. This can be used to implement advanced statistics/analysis
logic, which is beyond scope of Bitswap, but can be implemented as IPFS
plugin.
Some examples of potential applications:
I tried to implement the entire "tapping" mechanism in the least obstructing way.
Because entire messages are passed for external processing, range of possible applications is enormous.
I created PR (without prior issue), because change is small and a commit is worth a thousand words ;)