This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix: make blockstore cancel test less timing dependent #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
test/blockstore-test-timing
branch
from
90fd3a0
to
9ce8d48
Compare
1. More blocks so we have more time. 2. Lock less. 3. Put without the delay (so we can put more blocks without slowing things down).
Stebalien
force-pushed
the
test/blockstore-test-timing
branch
from
9ce8d48
to
a45ff1b
Compare
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…-timing fix: make blockstore cancel test less timing dependent This commit was moved from ipfs/go-bitswap@26c6c49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still timing dependent, but less timing dependent.