This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix: fix race on "responsive" check #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Sep 2, 2021
Stebalien
force-pushed
the
fix/responsive-check-race
branch
from
cbc36ab to
de1638f
Compare
Stebalien
force-pushed
the
fix/responsive-check-race
branch
from
de1638f to
e7f60bf
Compare
|
Added an extra check to return early if we don't know about the peer. |
|
This PR seems to be hitting some flaky tests that have not yet been reported in ipfs/boxo#86. Let's put up a PR to disable those tests, rebase and see if we have more flaky tests or something else is going on. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…-race fix: fix race on "responsive" check This commit was moved from ipfs/go-bitswap@fef017b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #527