Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Filecoin multicodecs #104

Merged
merged 1 commit into from
May 25, 2020
Merged

feat: add Filecoin multicodecs #104

merged 1 commit into from
May 25, 2020

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 12, 2020

  • fil-commitment-unsealed
  • fil-commitment-sealed

Ref: multiformats/multicodec#161
Ref: multiformats/multicodec#172

@welcome
Copy link

welcome bot commented May 12, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

* fil-commitment-unsealed
* fil-commitment-sealed

Ref: multiformats/multicodec#161
Ref: multiformats/multicodec#172
@rvagg
Copy link
Member Author

rvagg commented May 13, 2020

I can't get the Travis Branch run to happen, I force pushed a commit with an updated timestamp and it's still stuck on "Expected - Waiting for status to be reported". Travis PR runs fine though.

@Stebalien
Copy link
Member

🤷‍♂️

@rvagg
Copy link
Member Author

rvagg commented May 25, 2020

@Stebalien I think this is good to land, could you merge it please?

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections but is it even possible to define proper IPLD codecs for these?

@Stebalien Stebalien merged commit 95a7ed4 into ipfs:master May 25, 2020
@rvagg rvagg deleted the rvagg/filecoin-codecs branch May 26, 2020 04:37
@rvagg
Copy link
Member Author

rvagg commented May 26, 2020

The short answer is "partly". But we also purposefully didn't tag them as "ipld", or "serialization" in the multicodec table because (a) it's not as clear that these can be a clean & bi-directional serialization format and (b) it's not even clear that you'd ever want to use them in this way. We also still haven't received a clear answer regarding why these things need to be CIDs but we're going forward in good faith that there is (and that grokking the full "why" of any of these things is probably beyond the scope of multicodecs in general if multicodecs are to continue to scale). A pointer to a content-addressed thing of a particular, discernible type whose address is composed in a particular way - is partly (but not wholly) how I think it's being conceptualised.

Deep context can be found in this thread if anyone's interested in diving head-first: multiformats/multicodec#172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants