-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Filecoin multicodecs #104
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
* fil-commitment-unsealed * fil-commitment-sealed Ref: multiformats/multicodec#161 Ref: multiformats/multicodec#172
I can't get the Travis Branch run to happen, I force pushed a commit with an updated timestamp and it's still stuck on "Expected - Waiting for status to be reported". Travis PR runs fine though. |
🤷♂️ |
@Stebalien I think this is good to land, could you merge it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections but is it even possible to define proper IPLD codecs for these?
The short answer is "partly". But we also purposefully didn't tag them as "ipld", or "serialization" in the multicodec table because (a) it's not as clear that these can be a clean & bi-directional serialization format and (b) it's not even clear that you'd ever want to use them in this way. We also still haven't received a clear answer regarding why these things need to be CIDs but we're going forward in good faith that there is (and that grokking the full "why" of any of these things is probably beyond the scope of multicodecs in general if multicodecs are to continue to scale). A pointer to a content-addressed thing of a particular, discernible type whose address is composed in a particular way - is partly (but not wholly) how I think it's being conceptualised. Deep context can be found in this thread if anyone's interested in diving head-first: multiformats/multicodec#172 |
Ref: multiformats/multicodec#161
Ref: multiformats/multicodec#172