Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/base36 support #107

Merged
merged 5 commits into from
May 25, 2020
Merged

Chore/base36 support #107

merged 5 commits into from
May 25, 2020

Conversation

ribasushi
Copy link
Contributor

Bumps go-multibase and cleans up gx

@welcome
Copy link

welcome bot commented May 25, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@ribasushi ribasushi mentioned this pull request May 25, 2020
Closed
@ribasushi ribasushi requested review from Stebalien and lidel May 25, 2020 12:07
@ribasushi ribasushi mentioned this pull request May 25, 2020
Closed
@lidel lidel mentioned this pull request May 25, 2020
Closed
@lidel
test: lowercase base36
d683e92 
Base36 was introduced mainly for use in DNS, and various user agents
force lowercase, so tests should use that instead.

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel mentioned this pull request May 25, 2020
Closed
Stebalien
Stebalien approved these changes May 25, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@ribasushi
Copy link
Contributor Author

ribasushi commented May 25, 2020 •
edited
Loading

@lidel it actually supports both/mixed case:
https://github.com/ipfs/go-ipfs/pull/7358/files#diff-75bb25b8c588d7a9f610f117d14b64d7R159

@ribasushi ribasushi merged commit 85cd308 into master May 25, 2020
@mvdan mvdan deleted the chore/base36_support branch July 1, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ribasushi @Stebalien @lidel