Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Continuration of: Only allow crypto-safe hashes to be used in CIDs #50

Closed
wants to merge 8 commits into from
Closed

[WIP] Continuration of: Only allow crypto-safe hashes to be used in CIDs #50

wants to merge 8 commits into from

Commits on Jun 24, 2018

  1. add function to check if a given cid is safe

    @whyrusleeping @kevina
    whyrusleeping authored and kevina committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    8227f09 View commit details
    Browse the repository at this point in the history

  2. For now allow SHA1

    @Kubuxu @kevina
    Kubuxu authored and kevina committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    5729e62 View commit details
    Browse the repository at this point in the history

  3. Add testing for ValidateCid

    @Kubuxu @kevina
    Kubuxu authored and kevina committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    157fb41 View commit details
    Browse the repository at this point in the history

  4. Enforce the security rules of crypto-safe hashes and min length 

    See: ipfs/kubo#4371
    @Kubuxu @kevina
    Kubuxu authored and kevina committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    c4f3670 View commit details
    Browse the repository at this point in the history

  5. Define cidv0 error

    @Kubuxu @kevina
    Kubuxu authored and kevina committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    6ed0f32 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2018

  1. Tweak parameters of NewPrefix functions.

    @kevina
    kevina committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    c0f105f View commit details
    Browse the repository at this point in the history

  2. Provide better error messages in the case of insecure hashes.

    @kevina
    kevina committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    ece69b4 View commit details
    Browse the repository at this point in the history

  3. Enhance ValidateCid to also check for correct CIDv0 and use it in New… 

    …CidV0
    @kevina
    kevina committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    c0604b7 View commit details
    Browse the repository at this point in the history