Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make delete idempotent #132

Merged
merged 1 commit into from
Aug 21, 2019
Merged

feat: make delete idempotent #132

merged 1 commit into from
Aug 21, 2019

Conversation

Stebalien
Copy link
Member

fixes #104

@Stebalien
Copy link
Member Author

Let's not hold up a bugfix on feature bike-shedding.

dirkmc
dirkmc approved these changes Aug 21, 2019
View reviewed changes
Copy link

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Stebalien Stebalien merged commit 507733c into master Aug 21, 2019
@Stebalien Stebalien deleted the feat/idempotent-delete branch August 21, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define Delete to be idempotent
2 participants
@Stebalien @dirkmc