add context parameter to datastore interface #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Stebalien thoughts? I can't request reviewers anymore it seems... |
|
Is this just a rebase of https://github.com/ipfs/go-datastore/pull/161/files? |
|
It isn't because I failed to search PRs when checking whether this was done, and only searched issues. 🤦 |
|
Oops, sorry @lanzafame clicked the wrong PR by accident. We're merging #181 |
|
@aschmahmann no worries, just happy to see this has finally happened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds context.Context as the first parameter to the datastore interface. This allows for tracing and metrics tools to pass through the datastore interface, providing a better understanding of performance.
To allow for backwards compatibility, I would recommend that this be part of go-datastore/v2 allowing downstream packages to upgrade at their leisure.