Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement DiskUsage for the rest of the datastores #86

Merged
merged 3 commits into from
Mar 15, 2018

Conversation

Stebalien
Copy link
Member

No description provided.

@ghost ghost assigned Stebalien Mar 15, 2018
@ghost ghost added the status/in-progress In progress label Mar 15, 2018
@Stebalien Stebalien requested a review from hsanjuan March 15, 2018 03:17
@hsanjuan
Copy link
Contributor

hmm tests failing..

@Stebalien
Copy link
Member Author

Stebalien commented Mar 15, 2018

hmm tests failing..

we were using the wrong path for a package (path wasn't listed in the package's package.json)

I have no idea why this hasn't been failing for years. Maybe the test cache expired?

@Stebalien Stebalien merged commit 2dc0622 into master Mar 15, 2018
@ghost ghost removed the status/in-progress In progress label Mar 15, 2018
@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #86 into master will decrease coverage by 9.94%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   61.51%   51.57%   -9.95%     
==========================================
  Files           8       16       +8     
  Lines         408      952     +544     
==========================================
+ Hits          251      491     +240     
- Misses        141      429     +288     
- Partials       16       32      +16
Impacted Files Coverage Δ
autobatch/autobatch.go 50% <0%> (-2.64%) ⬇️
retrystore/retrystore.go 78.94% <0%> (-21.06%) ⬇️
namespace/namespace.go 63.63% <0%> (ø)
keytransform/interface.go 33.33% <0%> (ø)
key.go 74.77% <0%> (ø)
basic_ds.go 0% <0%> (ø)
keytransform/keytransform.go 46.87% <0%> (ø)
batch.go 0% <0%> (ø)
datastore.go 0% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2426c0...ca50820. Read the comment docs.

@Stebalien Stebalien deleted the feat/implement-du branch March 15, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants